-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kube registry and examples #271
Conversation
a3cf655
to
1ddc810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add doc plz
core/config/model/registry.go
Outdated
@@ -18,6 +18,7 @@ type RegistryStruct struct { | |||
Tenant string `yaml:"tenant"` | |||
AutoRegister string `yaml:"register"` | |||
APIVersion RegistryAPIVersionStruct `yaml:"api"` | |||
ConfigPath string `yaml:"configPath"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registry is deprecated, do not maintain, you can add this comment at the top
provide the doc |
need UT for kube controller |
core/registry/index.go
Outdated
@@ -137,3 +137,18 @@ func (m *MicroServiceInstance) WithAppID(v string) *MicroServiceInstance { | |||
m.Metadata[common.BuildinTagApp] = v | |||
return m | |||
} | |||
|
|||
// GetEndPointByProto get endpoint by protocol | |||
func (m *MicroServiceInstance) GetEndPointByProto(proto string) (string, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limit user k8s service port name naming convention, not use code to handle complicated scenario
493b4aa
to
1807509
Compare
No description provided.